DM-48879: Improve ip_diffim detectAndMeasure behavior around bright stars #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
force-pushed
the
tickets/DM-48879
branch
from
659e813 to
a6bc9ed
Compare
isullivan
approved these changes
Feb 11, 2025
Contributor
isullivan
left a comment
isullivan
left a comment
There was a problem hiding this comment.
I am surprised our unit tests pass with deblending off by default. I take it that is what John was referring to in group meeting this afternoon, about the missing commit from his deblending work last Spring.
My one request would be to move the mask plane config to a standalone commit.
Comment on lines
-218
to
-221
| "SAT", | ||
| "BAD", | ||
| "INTRP", | ||
| "NO_DATA", |
Contributor
There was a problem hiding this comment.
Minor point, but please move the excludeMaskPlanes changes to their own commit
ebellm
force-pushed
the
tickets/DM-48879
branch
from
a6bc9ed to
b4257dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.